feat[cuda]: SequenceArray #6232
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Duffy <[email protected]>
a10y
force-pushed
the
aduffy/seq-cuda
branch
4 times, most recently
from
627f533 to
f95d5ec
Compare
Signed-off-by: Andrew Duffy <[email protected]>
Comment on lines
+10
to
+25
| __device__ void sequence( | ||
| ValueT *const output, | ||
| ValueT base, | ||
| ValueT multiplier, | ||
| uint64_t len | ||
| ) { | ||
| const uint64_t worker = blockIdx.x * blockDim.x + threadIdx.x; | ||
|
|
||
| const uint64_t elemStart = MIN(worker * ELEMENTS_PER_THREAD, len); | ||
| const uint64_t elemEnd = MIN(elemStart + ELEMENTS_PER_THREAD, len); | ||
|
|
||
| for (uint64_t idx = elemStart; idx < elemEnd; idx++) { | ||
| output[idx] = static_cast<ValueT>(idx) * multiplier + base; | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
please can we be consistent with the others doing 32 units of work per thread, but set with a constant so its very easy to change moving forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.